Browse Source

preferences: Set autocomplete=off for form

Otherwise you can change the value of a select,
refresh the page and the preferences stay changed,
leaving the wrong impression that they were saved.
Martin Fischer 3 years ago
parent
commit
07936060d1

+ 1 - 1
searx/templates/oscar/preferences.html

@@ -94,7 +94,7 @@
 <div>
 
     <h1>{{ _('Preferences') }}</h1>
-    <form method="post" action="{{ url_for('preferences') }}" id="search_form">
+    <form method="post" action="{{ url_for('preferences') }}" id="search_form" autocomplete="off">
 
         <!-- Nav tabs -->
         <ul class="nav nav-tabs nav-justified hide_if_nojs" role="tablist">

+ 1 - 1
searx/templates/simple/preferences.html

@@ -98,7 +98,7 @@
 {% block content %}
 <h1>{{ _('Preferences') }}</h1>
 
-<form id="search_form" method="post" action="{{ url_for('preferences') }}">
+<form id="search_form" method="post" action="{{ url_for('preferences') }}" autocomplete="off">
 
 {{ tabs_open() }}
 

+ 1 - 1
tests/unit/test_webapp.py

@@ -186,7 +186,7 @@ class ViewsTestCase(SearxTestCase):
     def test_preferences(self):
         result = self.app.get('/preferences')
         self.assertEqual(result.status_code, 200)
-        self.assertIn(b'<form method="post" action="/preferences" id="search_form">', result.data)
+        self.assertIn(b'<form method="post" action="/preferences" id="search_form" autocomplete="off">', result.data)
         self.assertIn(b'<label class="col-sm-3 col-md-2" for="categories">Default categories</label>', result.data)
         self.assertIn(b'<label class="col-sm-3 col-md-2" for="locale">Interface language</label>', result.data)