Browse Source

[fix] ensure that test.pyright installs pyright

nodejs.ensure only sets up NVM if there isn't a system-wide
installation of Node that matches our NODE_MINIMUM_VERSION.

The ubuntu image in the CI comes with an up to date node version,
so pyright from .nvm_packages is never installed.

This commit fixes this by introducing a package.json file.
Martin Fischer 3 years ago
parent
commit
6d701d2fea
4 changed files with 10 additions and 2 deletions
  1. 3 0
      .gitignore
  2. 0 1
      .nvm_packages
  3. 2 1
      manage
  4. 5 0
      package.json

+ 3 - 0
.gitignore

@@ -16,3 +16,6 @@ dist/
 local/
 gh-pages/
 *.egg-info/
+
+/package-lock.json
+/node_modules/

+ 0 - 1
.nvm_packages

@@ -5,5 +5,4 @@
 # [1] https://github.com/nvm-sh/nvm#default-global-packages-from-file-while-installing
 
 eslint
-pyright
 

+ 2 - 1
manage

@@ -687,9 +687,10 @@ test.pylint() {
 test.pyright() {
     build_msg TEST "[pyright] static type check of python sources"
     nodejs.ensure
+    npm install
     # We run Pyright in the virtual environment because Pyright
     # executes "python" to determine the Python version.
-    pyenv.cmd pyright -p pyrightconfig-ci.json
+    pyenv.cmd npx --no-install pyright -p pyrightconfig-ci.json
     dump_return $?
 }
 

+ 5 - 0
package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "pyright": "^1.1.212"
+  }
+}