Browse Source

Merge pull request #548 from searxng/dependabot/pip/master/selenium-4.1.0

Bump selenium from 3.141.0 to 4.1.0
Alexandre Flament 3 years ago
parent
commit
7bef2cc8dc
2 changed files with 5 additions and 6 deletions
  1. 3 4
      manage
  2. 2 2
      requirements-dev.txt

+ 3 - 4
manage

@@ -21,7 +21,7 @@ source "$(dirname "${BASH_SOURCE[0]}")/utils/lib_go.sh"
 
 PYOBJECTS="searx"
 PY_SETUP_EXTRAS='[test]'
-GECKODRIVER_VERSION="v0.28.0"
+GECKODRIVER_VERSION="v0.30.0"
 export NODE_MINIMUM_VERSION="16.13.0"
 # SPHINXOPTS=
 
@@ -485,10 +485,9 @@ gecko.driver() {
     (   set -e
         pyenv.activate
 
-        # TODO : check the current geckodriver version
-        geckodriver -V > /dev/null 2>&1 || NOTFOUND=1
+        INSTALLED_VERSION=$(geckodriver -V 2> /dev/null | head -1 | awk '{ print "v" $2}') || INSTALLED_VERSION=""
         set +e
-        if [ -z "$NOTFOUND" ]; then
+        if [ "${INSTALLED_VERSION}" = "${GECKODRIVER_VERSION}" ]; then
             build_msg INSTALL "geckodriver already installed"
             return
         fi

+ 2 - 2
requirements-dev.txt

@@ -3,8 +3,8 @@ nose2[coverage_plugin]==0.10.0
 cov-core==1.15.0
 pycodestyle==2.8.0
 pylint==2.12.2
-splinter==0.16.0
-selenium==3.141.0
+splinter==0.17.0
+selenium==4.1.0
 twine==3.7.1
 Pallets-Sphinx-Themes==2.0.2
 Sphinx==4.3.1