Browse Source

Don't hardcode uWSGI parameters (#4578)

* Initial update

* fix

* add todo note
Ivan Gabaldon 3 weeks ago
parent
commit
9424bac031
3 changed files with 9 additions and 7 deletions
  1. 1 0
      Dockerfile
  2. 4 7
      dockerfiles/docker-entrypoint.sh
  3. 4 0
      dockerfiles/uwsgi.ini

+ 1 - 0
Dockerfile

@@ -12,6 +12,7 @@ RUN addgroup -g ${SEARXNG_GID} searxng && \
 ENV INSTANCE_NAME=searxng \
     AUTOCOMPLETE= \
     BASE_URL= \
+    BIND_ADDRESS=[::]:8080 \
     MORTY_KEY= \
     MORTY_URL= \
     SEARXNG_SETTINGS_PATH=/etc/searxng/settings.yml \

+ 4 - 7
dockerfiles/docker-entrypoint.sh

@@ -14,8 +14,6 @@ Environment variables:
   BASE_URL      settings.yml : server.base_url
   MORTY_URL     settings.yml : result_proxy.url
   MORTY_KEY     settings.yml : result_proxy.key
-  BIND_ADDRESS  uwsgi bind to the specified TCP socket using HTTP protocol.
-                Default value: ${DEFAULT_BIND_ADDRESS}
 Volume:
   /etc/searxng  the docker entry point copies settings.yml and uwsgi.ini in
                 this directory (see the -f command line option)"
@@ -23,9 +21,6 @@ Volume:
 EOF
 }
 
-export DEFAULT_BIND_ADDRESS="[::]:8080"
-export BIND_ADDRESS="${BIND_ADDRESS:-${DEFAULT_BIND_ADDRESS}}"
-
 # Parse command line
 FORCE_CONF_UPDATE=0
 DRY_RUN=0
@@ -173,6 +168,8 @@ fi
 
 unset MORTY_KEY
 
-# Start uwsgi
 printf 'Listen on %s\n' "${BIND_ADDRESS}"
-exec uwsgi --master --uid searxng --gid searxng --http-socket "${BIND_ADDRESS}" "${UWSGI_SETTINGS_PATH}"
+
+# Start uwsgi
+# TODO: "--http-socket" will be removed in the future (see uwsgi.ini.new config file): https://github.com/searxng/searxng/pull/4578
+exec uwsgi --http-socket "${BIND_ADDRESS}" "${UWSGI_SETTINGS_PATH}"

+ 4 - 0
dockerfiles/uwsgi.ini

@@ -1,4 +1,8 @@
 [uwsgi]
+# Listening address
+# default value: [::]:8080 (see Dockerfile)
+http-socket = $(BIND_ADDRESS)
+
 # Who will run the code
 uid = searxng
 gid = searxng