Browse Source

[fix] unit test_xpath.py: name 'logger' is not defined

Depending on the order in which the unit tests are executed, the python modules
of the engines are initialized (monkey patched) or not. As the order of the
tests is not static, random errors may occur.

To avaoid random `NameError: name 'logger' is not defined` in the unit tests of
the xpath engine, a logger is monkey patched into the xpath py-module.

```
make test.unit
TEST      tests/unit
......EE...................
======================================================================
ERROR: test_response (tests.unit.engines.test_xpath.TestXpathEngine.test_response)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./tests/unit/engines/test_xpath.py", line 60, in test_response
    self.assertEqual(xpath.response(response), [])
                     ^^^^^^^^^^^^^^^^^^^^^^^^
  File "./searx/engines/xpath.py", line 309, in response
    logger.debug("found %s results", len(results))
    ^^^^^^
NameError: name 'logger' is not defined

======================================================================
ERROR: test_response_results_xpath (tests.unit.engines.test_xpath.TestXpathEngine.test_response_results_xpath)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./tests/unit/engines/test_xpath.py", line 102, in test_response_results_xpath
    self.assertEqual(xpath.response(response), [])
                     ^^^^^^^^^^^^^^^^^^^^^^^^
  File "./searx/engines/xpath.py", line 309, in response
    logger.debug("found %s results", len(results))
    ^^^^^^
NameError: name 'logger' is not defined
```

Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Markus Heiser 10 months ago
parent
commit
d80fcbc635
1 changed files with 8 additions and 0 deletions
  1. 8 0
      tests/unit/engines/test_xpath.py

+ 8 - 0
tests/unit/engines/test_xpath.py

@@ -3,9 +3,14 @@
 
 from collections import defaultdict
 import mock
+
 from searx.engines import xpath
+from searx import logger
+
 from tests import SearxTestCase
 
+logger = logger.getChild('engines')
+
 
 class TestXpathEngine(SearxTestCase):  # pylint: disable=missing-class-docstring
     html = """
@@ -23,6 +28,9 @@ class TestXpathEngine(SearxTestCase):  # pylint: disable=missing-class-docstring
     </div>
     """
 
+    def setUp(self):
+        xpath.logger = logger.getChild('test_xpath')
+
     def test_request(self):
         xpath.search_url = 'https://url.com/{query}'
         xpath.categories = []